Skip to content

Accept padded DataChannelAck, fix closing DataChannel #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickel8 merged 1 commit into from
Mar 17, 2025
Merged

Accept padded DataChannelAck, fix closing DataChannel #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ex_webrtc/sctp_transport.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ if Code.ensure_loaded?(ExSCTP) do

ExSCTP.close_stream(sctp_transport.ref, id)

case Enum.find_value(sctp_transport.channels, fn {_k, v} -> v.id == id end) do
case Enum.find(sctp_transport.channels, fn {_k, v} -> v.id == id end) do
{ref, %DataChannel{}} ->
channels = Map.delete(sctp_transport.channels, ref)
stats = Map.delete(sctp_transport.stats, ref)
Expand Down
2 changes: 2 additions & 0 deletions lib/ex_webrtc/sctp_transport/dcep.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ defmodule ExWebRTC.SCTPTransport.DCEP do
defstruct []

def decode(<<>>), do: {:ok, %__MODULE__{}}
# Some implementations (e.g. Pion) seems to pad DataChannelAck to 4 bytes. Accept them.
def decode(<<_, _, _>>), do: {:ok, %__MODULE__{}}
def decode(_other), do: :error

def encode(%__MODULE__{}), do: <<0x02>>
Expand Down