-
Notifications
You must be signed in to change notification settings - Fork 41
Support providing a fake Browser.Navigation.Key in tests #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jfmengels
wants to merge
8
commits into
elm-explorations:master
Choose a base branch
from
jfmengels:navigation-key
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9136e02
Fix typo in test title
jfmengels e67c5a3
Add dependency to elm/browser
jfmengels efe28f7
Add type annotations
jfmengels a1ac53a
Define a test navigation key
jfmengels 43a5cb1
Add Test.testWithKey
jfmengels cb43920
Add Test.fuzzWithKey
jfmengels 17e1d05
Add tests for withKey functions
jfmengels 5a40402
Update wording
jfmengels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,5 @@ function _Test_runThunk(thunk) | |
return __Result_Err(err.toString()); | ||
} | ||
} | ||
|
||
function _Test_navigationKey() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
module BrowserTests exposing (all) | ||
|
||
import Browser.Navigation | ||
import Expect | ||
import Fuzz | ||
import Test exposing (Test, describe) | ||
|
||
|
||
all : Test | ||
all = | ||
Test.concat | ||
[ testWithKey | ||
, fuzzWithKey | ||
] | ||
|
||
|
||
testWithKey : Test | ||
testWithKey = | ||
Test.testWithKey "Test.testWithKey: storing, using or comparing the key should not have any noticeable effect" <| | ||
\navKey -> | ||
let | ||
init : { navKey : Browser.Navigation.Key } | ||
init = | ||
{ navKey = navKey } | ||
in | ||
( init, cmdsUsingKey navKey ) | ||
|> Tuple.first | ||
|> Expect.equal { navKey = navKey } | ||
|
||
|
||
fuzzWithKey : Test | ||
fuzzWithKey = | ||
Test.fuzzWithKey Fuzz.int "Test.fuzzWithKey: storing, using or comparing the key should not have any noticeable effect" <| | ||
\navKey number -> | ||
let | ||
init : { navKey : Browser.Navigation.Key, number : Int } | ||
init = | ||
{ navKey = navKey, number = number } | ||
in | ||
( init, cmdsUsingKey navKey ) | ||
|> Tuple.first | ||
|> Expect.equal { navKey = navKey, number = number } | ||
|
||
|
||
cmdsUsingKey : Browser.Navigation.Key -> Cmd msg | ||
cmdsUsingKey navKey = | ||
Cmd.batch | ||
[ Browser.Navigation.pushUrl navKey "some-url" | ||
, Browser.Navigation.replaceUrl navKey "some-url" | ||
, Browser.Navigation.back navKey 1 | ||
, Browser.Navigation.forward navKey 1 | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether this is as low as we can go, or whether 1.0.1 or 1.0.2 have something important we want to encourage adoption of.
(We did that with bytes 1.0.8 I think, where there was something substantial... but I can't remember the details)