Skip to content

Conversation

@AlexImb
Copy link
Member

@AlexImb AlexImb commented Nov 1, 2025

This pull request contains changes generated by a Cursor Cloud Agent

Open in Cursor Open in Web


Note

Adds a close selector setting and clear-file action that clears bound elements, with a demo "Remove file" button wired to it.

  • Core (src/uppload.ts):
    • Add clearselectedfile() to reset bound elements' src/value and emit bind.
    • Wire new settings.close elements to trigger clearselectedfile() via click handlers.
  • Types (src/helpers/interfaces.ts):
    • Add close?: IElements to IUpploadSettings.
  • Demo/UI:
    • index.html: add "Remove file" button (.on-clear).
    • demo/index.ts: pass close: ".on-clear" in Uppload config.

Written by Cursor Bugbot for commit 191b0cf. This will update automatically on new commits. Configure here.

@cursor
Copy link

cursor bot commented Nov 1, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@AlexImb AlexImb marked this pull request as ready for review November 1, 2025 15:09
@AlexImb AlexImb requested a review from victorlap November 1, 2025 15:09
@AlexImb
Copy link
Member Author

AlexImb commented Nov 1, 2025

@cursor check this out

@cursor
Copy link

cursor bot commented Nov 1, 2025

Thanks for flagging! I reviewed PR #1009—tests and build pass, and the new close selector cleanly clears bound elements. I’ve merged it into the review branch; only follow-up thought is maybe camel-case clearselectedfile later for consistency.


Open in Cursor Open in Web

Learn more about Cursor Agents

@AlexImb
Copy link
Member Author

AlexImb commented Nov 1, 2025

Thanks for flagging! I reviewed PR #1009—tests and build pass, and the new close selector cleanly clears bound elements. I’ve merged it into the review branch; only follow-up thought is maybe camel-case clearselectedfile later for consistency.

Open in Cursor Open in Web

Learn more about Cursor Agents

It's a good suggestion. Please make it camelCase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants