fix: fixes error when a utility frame is the current frame #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this fixes the issue on OSX. Guys, could you please give this some attention? This bug completely breaks dap-mode on OSX. GNU Emacs 29.4 (build 1, aarch64-apple-darwin24.3.0, NS appkit-2575.40 Version 15.3.1 (Build 24D70)) of 2025-02-25 |
|
@jcs090218 Sorry for the direct ping, but would you be able to take a look at this? It also fixes dap-java for me locally (also using Mac OS X, Emacs 29) |
On Mac OS X, small frames that don't seem to have any windows may be selected when the process filter is processed. By walking up the parent-frame list, we can get to the frame that the user is actually able to use, and thus the call to (get-mru-window) does not return nil and the whole process filter aborts. Should fix bug emacs-lsp#828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac OS X, small frames that don't allow user focus may be selected when the process filter is processed. By walking up the parent-frame list, we can get to the frame that the user is actually able to use, and thus the call to (get-mru-window) does not return nil and the whole process filter aborts.
Should fix bug #828