Skip to content

lsp-update-inlay-hint only remove (start-end) range overlays #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lsp-update-inlay-hint only remove (start-end) range overlays #4759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lsp-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6332,10 +6332,12 @@ execute a CODE-ACTION-KIND action."
(2 . lsp-face-highlight-read)
(3 . lsp-face-highlight-write)))

(defun lsp--remove-overlays (name)
(defun lsp--remove-overlays (name &optional beg end)
(save-restriction
(widen)
(remove-overlays (point-min) (point-max) name t)))
(remove-overlays (or beg (point-min))
(or end (point-max))
name t)))

(defun lsp-document-highlight ()
"Highlight all relevant references to the symbol under point."
Expand Down Expand Up @@ -9984,7 +9986,7 @@ string."
:end
(lsp-point-to-position end)))
(lambda (res)
(lsp--remove-overlays 'lsp-inlay-hint)
(lsp--remove-overlays 'lsp-inlay-hint start end)
(dolist (hint res)
(-let* (((&InlayHint :label :position :kind? :padding-left? :padding-right?) hint)
(kind (or kind? lsp/inlay-hint-kind-type-hint))
Expand Down
Loading