Add Nextflow download #4830
Open
Add Nextflow download #4830
+271
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids hanging and blocking the UI on large files This doesn't happen with small files (1.9MB Magik) but does happen with large files (12.6MB Nextflow)
edmundmiller
force-pushed
the
nextflow-download
branch
from
3ee87e5 to
9c8a732
Compare
jcs090218
approved these changes
Jul 29, 2025
jcs090218
reviewed
Aug 21, 2025
|
|
||
| ;; Define the core download function that we're testing | ||
| ;; This is a copy of the actual implementation from lsp-mode.el | ||
| (defun lsp-download-install--url-retrieve (url file callback error-callback) |
There was a problem hiding this comment.
Do we need to copy this here? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new entry to CHANGELOG.md
[] I updated documentation if applicable (
docsfolder)This is the download functionality for the Nextflow LSP, which then hangs. So then I implemented a download of large files, and then I refactor that to just work with any of them, to just improve the download functionality across the board.