-
-
Notifications
You must be signed in to change notification settings - Fork 70
Add Target Action Support deprecation guide #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
--- | ||
title: Deprecate Target Action Support | ||
until: 7.0.0 | ||
since: 6.8.0 | ||
--- | ||
|
||
The `actions` hash on components, controllers, and routes, along with the `send` method, is deprecated. These APIs were primarily used with the now-deprecated `{{action}}` modifier and helper. | ||
|
||
The modern approach is to use standard class methods decorated with the `@action` decorator, and to pass functions directly. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. speaking of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't we just deprecate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could -- tho that would be hugely disruptive across the ecosystem, so I think I'd want to wait a smidge. There was huge resistance to deprecating maybe that'll change once the alternative ships |
||
|
||
### `actions` hash and `send` | ||
|
||
**Old Pattern** | ||
|
||
Previously, you would define actions in an `actions` hash and use `this.send('actionName')` to call them. | ||
|
||
```javascript | ||
// app/components/my-component.js | ||
import Component from '@ember/component'; | ||
|
||
export default Component.extend({ | ||
actions: { | ||
save() { | ||
// ... saving logic | ||
}, | ||
cancel() { | ||
// ... cancel logic | ||
} | ||
}, | ||
|
||
someMethod() { | ||
this.send('save'); | ||
} | ||
}); | ||
``` | ||
|
||
**New Pattern** | ||
|
||
With modern classes, you can define methods directly on the class and decorate them with `@action`. You can then call them like any other method. | ||
|
||
```javascript | ||
// app/components/my-component.js | ||
import Component from '@glimmer/component'; | ||
import { action } from '@ember/object'; | ||
|
||
export default class MyComponent extends Component { | ||
@action | ||
save() { | ||
// ... saving logic | ||
} | ||
|
||
@action | ||
cancel() { | ||
// ... cancel logic | ||
} | ||
|
||
someMethod() { | ||
this.save(); | ||
} | ||
} | ||
``` |
Uh oh!
There was an error while loading. Please reload this page.