WIP Enable embroider for this app #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge. Styling is broken with the changes I made in this PR. Anyone who wants to help with this, please go for it!
It would be good to have some of our ember-learn apps using embroider so we can help catch any issues, and figure out what people will need in terms of support, troubleshooting, etc.
So far, I have enabled embroider and part of its options. Currently, the footer CSS (provided by ember-styleguide) is broken/missing when you turn on Embroider. Enabling more of them breaks styles completely.
Some ideas to investigate: