Skip to content

Conversation

@patricklx
Copy link
Collaborator

Description

resolves #2632

Screenshots

Screenshot 2025-06-26 at 17 15 25

@RobbieTheWagner
Copy link
Member

What problem is this solving?

@patricklx
Copy link
Collaborator Author

This is an alternative to the focus mode. or extra way to quickly see the parents of current component and select one of them for inspection
Might be easier/faster than through the component tree

@RobbieTheWagner
Copy link
Member

Could we make this be in top down order? Like application route first, then other routes, then component parent, then child? I think we should also make it more visually tree like and appealing to the eye.

@NullVoxPopuli
Copy link
Contributor

visually tree like

in big apps it would indent off the screen tho.

I think it should be upside down like a stack trace

@RobbieTheWagner
Copy link
Member

visually tree like

in big apps it would indent off the screen tho.

I think it should be upside down like a stack trace

It doesn't have to indent much, it's just unclear what I am looking at if I am a casual user and I think we could find a way to represent this better.

@NullVoxPopuli
Copy link
Contributor

some stack traces do:

most recent
at: next
at: above that
at: great grand parent

so maybe;

top of stack
in: parent 
in: grand parent
in: great grand parent
in: etc

🤷

@patricklx
Copy link
Collaborator Author

I used the same design react devtools has.
It might be unclear in the screenshot because its a production app and does not have the real names

pichfl
pichfl previously requested changes Aug 4, 2025
Copy link
Contributor

@pichfl pichfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works well enough, but the implementation could be a bit less involved.

Not doing indentation is good to me. Doing only slight increments would not feel intentional enough to be perceived as a feature.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving and merging this because the functionality is there 👍 If we have any questions about the right implementation and the order of rendering we can open them up in follow-up PRs 👍

@mansona mansona dismissed pichfl’s stale review August 6, 2025 12:49

Fixed the issues

@mansona mansona merged commit 821b9fb into emberjs:main Aug 6, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Each component should have a summary of its parents -- which is easier to read than trying to view the actual tree

5 participants