-
Notifications
You must be signed in to change notification settings - Fork 292
show parents in sidebar #2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show parents in sidebar #2667
Conversation
|
What problem is this solving? |
|
This is an alternative to the focus mode. or extra way to quickly see the parents of current component and select one of them for inspection |
|
Could we make this be in top down order? Like application route first, then other routes, then component parent, then child? I think we should also make it more visually tree like and appealing to the eye. |
in big apps it would indent off the screen tho. I think it should be upside down like a stack trace |
It doesn't have to indent much, it's just unclear what I am looking at if I am a casual user and I think we could find a way to represent this better. |
|
some stack traces do: so maybe; 🤷 |
|
I used the same design react devtools has. |
pichfl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works well enough, but the implementation could be a bit less involved.
Not doing indentation is good to me. Doing only slight increments would not feel intentional enough to be perceived as a feature.
mansona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving and merging this because the functionality is there 👍 If we have any questions about the right implementation and the order of rendering we can open them up in follow-up PRs 👍
Description
resolves #2632
Screenshots