-
-
Couldn't load subscription status.
- Fork 4.2k
Add a test that verifies @model is stable between route transitions
#20959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add a test that verifies @model is stable between route transitions
#20959
Conversation
This test doesn't actually reproduce the problem since a Glimmer component seems needed for that.
Estimated Asset SizesDiff Details
|
c96149a to
e5ba618
Compare
90cddad to
2622225
Compare
We now import the `@glimmer/component` package in test files which requires it to be built before Vite runs.
|
do you happen to know if this ever worked? |
I don't think so, no. As far as I know it has been an issue since It's just a tricky to reproduce issue so it seemed that it was "solved" at some point in time. |
This adds a failing test for the issue mentioned in #18987 based on the StackBlitz reproduction and supersedes #19257.
I needed to do some changes to the Vite and CI setup to make the
@glimmer/componentimports working in the test files. Not sure if what I did is the best solution but it works for the reproduction at least.