Rename Entity to Reader #186
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entity doesn't make it clear that the message can only be consumed once and is inconsistent with Writer.
rjarry
suggested changes
Jan 13, 2025
| mediaType string | ||
| mediaParams map[string]string | ||
| } | ||
| type Entity = Reader |
There was a problem hiding this comment.
Could you add a comment indicating that this symbol is deprecated and should not be used anymore?
|
I'm not quite sure this is worth the churn. In particular, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity doesn't make it clear that the message can only be consumed once and is inconsistent with Writer.