Skip to content

Ignore all webkit, ms and Mozilla specific pseudo elements #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ignore all webkit, ms and Mozilla specific pseudo elements #3150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1318ca8
Add -webkit-scrollbar pseudo-elements to ignored prefixes
silaslenz Jan 17, 2024
98b889a
Replace regex for specific pseudo-elements with a check for any webki…
silaslenz Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-drinks-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@emotion/sheet': patch
---

Do not log failed rule insertions in the speedy mode for vendor-prefixed (Webkit, Mozilla and Microsoft) pseudo-elements/classes
4 changes: 1 addition & 3 deletions packages/sheet/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,7 @@ export class StyleSheet {
} catch (e) {
if (
process.env.NODE_ENV !== 'production' &&
!/:(-moz-placeholder|-moz-focus-inner|-moz-focusring|-ms-input-placeholder|-moz-read-write|-moz-read-only|-ms-clear|-ms-expand|-ms-reveal){/.test(
rule
)
!/:(-webkit-.*:.*|-moz-.*|-ms-.*){/.test(rule)
) {
console.error(
`There was a problem inserting the following rule: "${rule}"`,
Expand Down