Implment RTDL_LOCAL and RTDL_NOW/RTDL_LAZY dlopen flags #15339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
rtld_local
branch
2 times, most recently
from
097348e to
dc85fb4
Compare
|
remind me what |
kripken
reviewed
Oct 21, 2021
| throw Error('undefined symbol: ' + symbol); | ||
| } | ||
| } | ||
| } | ||
| reportUndefinedSymbols(); |
There was a problem hiding this comment.
Maybe add a comment here? I had to read this a few times before I realized the new code checks for undefined symbols in stubs, while the call to reportUndefinedSymbols does the rest.
Actually, can that function do everything, and get the stubs as an optional param?
There are two changed here in the implementation of dlopen: 1. Avoid calling updateGOT when RTDL_LOCAL is set. 2. Check for undefined stub functions during postInstantiate. The reason we can't just avoid the stub functions completely here is the a module could both import and export a given symbol.
|
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changed here in the implementation of dlopen:
The reason we can't just avoid the stub functions completely here
is the a module could both import and export a given symbol.