WebIDL Binder const char* return type handled correctly #15651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDLlo
changed the title
CDLlo
changed the title
CDLlo
changed the title
|
This seems to also suffer from a CircleCI bug with not getting CI runs started. Sorry for this annoyance, I'm not sure what's wrong on their side. Hopefully they will respond soon to the ticket I opened for #15023 |
|
I am told by CircleCI that this bug with builds not starting may be worked around if you have a CircleCI account. If you do, then clicking the "Refresh Permissions" button on the "User Settings" page should do it. (If you do not have an account, then I'm not sure what's wrong, and I'll need to follow up with them.) |
|
Actually builds seem to be running now after I resolved the merge conflict... |
|
|
Making a separate branch for an up to date PR. Also added original author to AUTHORS file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a separate PR for the changes in the prior PR by ArthurG0. Unfortunately the branch being pulled from is not available for me to update/rebase and ArthurG0 left our company so it is not expected of them to follow up on the necessary changes for the stale PR to be accepted. I added them to the AUTHORS file in this branch to keep record of their contributions.
To restate the original PR, the original issue was that the WebIDL Binder was incorrectly handling the const char* return type as it treated it as an
intrather than achar*. The fix allows the basic type to be cast into the correct type in the generated glue code.