Sort members of EmccOptions. NFC #25687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
sort_options
branch
3 times, most recently
from
ad8bc18 to
278457d
Compare
Also, use class variables instead of instance fields. This doesn't change the semantics (at least not the way we use this class) and it saves a little bit of visual noise. The other nice thing this would allow if we ever wanted to to it is to compare the current option with its default (by comparing `self.foo` with `__class__.foo`, the default value).
kripken
approved these changes
Oct 29, 2025
| use_closure_compiler = None | ||
| use_preload_cache = False | ||
| use_preload_plugins = False | ||
| valid_abspaths: List[str] = [] |
There was a problem hiding this comment.
Looks like this also added types? They seem right.
There was a problem hiding this comment.
Yeas, for some reason mypy requires them to be typed when they are of this form. Not sure why types were not needed before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use class variables instead of instance fields. This doesn't
change the semantics (at least not the way we use this class) and it
saves a little bit of visual noise.