Skip to content

Conversation

@juj
Copy link
Collaborator

@juj juj commented Nov 28, 2025

Mark test_posix_proxy_sockets to depend on multithreading to skip it in old non-SAB capable browsers.

@juj
Copy link
Collaborator Author

juj commented Nov 28, 2025

Ruff is failing on organize imports, and doesn't tell me what I should do. When I run ruff locally, it says all checks passed. @sbc100 would you have a gospel ruff installed to give a diff?

@sbc100
Copy link
Collaborator

sbc100 commented Nov 29, 2025

Ruff is failing on organize imports, and doesn't tell me what I should do. When I run ruff locally, it says all checks passed. @sbc100 would you have a gospel ruff installed to give a diff?

Yes, but if you are unable to using requirements-dev.txt we should figure out a solution to that. Can you try using pip to install into a sub-directory and then running ./my-local-pip-install/bin/ruff?

TBH, I often add just do pip3 install -r requirements-dev.txt --break-system-packages but I guess that adding --break-system-packages might seem scary.

The alternative is to run pip3 with --target ./my-local-pip-install or use a python virtualenv (which basically does the same thing).

@juj
Copy link
Collaborator Author

juj commented Dec 4, 2025

The issue is not that I would not be able to install ruff, but the issue is that it does not report any problem with the code.

I am not scared to add --break-system-packages.

After pip3 install requirements-dev.txt, ruff --version gives 0.14.1, but ruff check says All checks passed!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants