[AUDIO_WORKLET] Rewrite lock test to be more realistic #25904
+149
−131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rethink of the lock test to do something locks would actually be used for: maintain atomicity of a complex data structure. We have this dummy struct with three members:
A series of calculations are performed thousands of times from both the main and audio thread, involving all the members. Without locks the steps are interleaved, resulting in the wrong result at the end.
It simulates a queue, for example, or any other container. Comment out the
emscripten_lock_busyspin_wait_acquire()call and it will fail (with a shorter number of iterations sometimes it would get lucky, but running intensively for a few seconds ensures failure without locks).