Skip to content

Closes #144, add canonical_into_vec, canonical_into_writer, canonical_value #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

Closes #144, add canonical_into_vec, canonical_into_writer, canonical_value #155

merged 1 commit into from
Jun 11, 2025

Conversation

zensh
Copy link
Contributor

@zensh zensh commented Jun 8, 2025

Closes #144, add canonical_into_vec, canonical_into_writer and canonical_value

@zensh zensh requested a review from a team as a code owner June 8, 2025 05:00
@zensh zensh requested a review from rvolosatovs June 8, 2025 05:00
@rjzak
Copy link
Member

rjzak commented Jun 8, 2025

I fixed the error you encountered. Rebase and try again.

@zensh
Copy link
Contributor Author

zensh commented Jun 9, 2025

@rjzak
Thank you for the quick response. Many are awaiting the rfc8949 canonicalization feature, hoping ciborium can address it. I like ciborium's implementation.

@rjzak
Copy link
Member

rjzak commented Jun 9, 2025

Just looks like some no_std issues.

rjzak
rjzak approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@rjzak rjzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjzak rjzak merged commit 1b60854 into enarx:main Jun 11, 2025
53 of 54 checks passed
@zensh
Copy link
Contributor Author

zensh commented Jun 11, 2025

@rjzak
Excited for v0.2.3! It's been over a year since v0.2.2 👀

@hoxxep
Copy link
Contributor

hoxxep commented Jun 11, 2025

@rjzak @zensh excellent! 🙏 This might also close #143, unless that implementation is still being considered for a future major release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzak rjzak rjzak approved these changes

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs rvolosatovs is a code owner automatically assigned from enarx/codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: rfc8949 canonicalization
3 participants
@zensh @rjzak @hoxxep