Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

pytest anyio #101

Merged
merged 14 commits into from
Aug 24, 2021
Merged

pytest anyio #101

merged 14 commits into from
Aug 24, 2021

Conversation

aminalaee
Copy link
Contributor

@aminalaee aminalaee commented Aug 20, 2021 •
edited
Loading

Add pytest anyio

graingert
graingert suggested changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to use @pytest.mark.anyio

@aminalaee
Copy link
Contributor Author

aminalaee commented Aug 20, 2021 •
edited
Loading

@graingert Thanks. But anyio is not required in orm. Do you mean we add that too?

@graingert
Copy link
Contributor

afaik, orm and databases are designed with Starlette in mind and so should also work with anyio eventually

@aminalaee aminalaee requested a review from graingert August 20, 2021 10:10
@aminalaee aminalaee changed the title pytest-asyncio pytest-anyio Aug 24, 2021
graingert
graingert suggested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyio is only a test dep for now

@aminalaee aminalaee requested a review from graingert August 24, 2021 11:46
@aminalaee aminalaee changed the title pytest-anyio pytest anyio Aug 24, 2021
@aminalaee aminalaee merged commit ec54759 into encode:master Aug 24, 2021
@aminalaee aminalaee deleted the pytest-asyncio branch August 24, 2021 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@graingert graingert Awaiting requested review from graingert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminalaee @graingert