Fix default input device when no joypad is connected #1328
Merged
+3
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 0a547d0 I simplified the way that our input hint components choose a default device: rather than reimplementing Input Helper's device detection, we use a pair of properties from the helper. Unfortunately I picked the wrong ones: I used last_known_joypad_device and last_known_joypad_index. As the name suggests, the last_known_joypad_device will never be "keyboard". Its docstring claims it will be "" if no gamepad is connected; in fact it is currently "generic", which I submitted nathanhoad/godot_input_helper#87 to fix. As a result, if you have no gamepad connected, then gamepad hints will always be shown. Instead, use InputHelper.device and InputHelper.device_index, which are the type and index of the last device that the player used to control the game. Before any input events have been received, these default to joypad 0 if there is a joypad connected, and "keyboard" / -1 if not.
wjt
changed the title
wjt
changed the title
|
Play this branch at https://endlessm.github.io/threadbare/branches/endlessm/wjt/fix-default-input-device-when-no-joypad-is-connected. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Oct 13, 2025
manuq
deleted the
wjt/fix-default-input-device-when-no-joypad-is-connected
branch
|
I'm kind of tempted to make a new release for this, it's an annoying bug in a highlighted feature in v0.1.5. Completely my fault! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 0a547d0 I simplified the way
that our input hint components choose a default device: rather than
reimplementing Input Helper's device detection, we use a pair of
properties from the helper.
Unfortunately I picked the wrong ones: I used last_known_joypad_device
and last_known_joypad_index. As the name suggests, the
last_known_joypad_device will never be "keyboard". Its docstring claims
it will be "" if no gamepad is connected; in fact it is currently
"generic", which I submitted
nathanhoad/godot_input_helper#87 to fix.
As a result, if you have no gamepad connected, then gamepad hints will
always be shown.
Instead, use InputHelper.device and InputHelper.device_index, which are
the type and index of the last device that the player used to control
the game. Before any input events have been received, these default to
joypad 0 if there is a joypad connected, and "keyboard" / -1 if not.