Skip to content

Conversation

@Jake2420
Copy link

Cambios por el grupo1

@Jake2420 Jake2420 requested review from a team as code owners October 23, 2025 19:15
@wjt
Copy link
Member

wjt commented Oct 24, 2025

The Revert "Update" commit means that we can't merge this: Git wants to apply that same change to the upstream repository.

@Jake2420 @JuaniCargnel I suggest you do the following:

  • Disable branch protection on your fork
  • Reset main in your fork to match endlessm:main
  • Rebase the Agregando storyquest del grupo 1 commit onto main

@wjt wjt added the StoryQuest New StoryQuests or updates to existing ones label Oct 24, 2025
@JuaniCargnel
Copy link
Contributor

Hi @wjt! Sorry about that — this was a mistake from the students, they never canceled the PR! They just forgot to change it so that the PR would go to the org main branch.

Regarding the “Revert Update,” that was me — I did it when we had to update the ORGs. I had made a PR to update them, but then the option to disable protection came up, so I did the revert to make all the ORGs consistent... it didn’t work i guess, haha. Could that cause problems in the future? Everything should be fine now, but I might have messed something up — sorry about that.

@wjt
Copy link
Member

wjt commented Oct 24, 2025

@JuaniCargnel main...Game-Lab-5-0-UTP-Grupo-2-Equipo-1:threadbare:main shows that you have a revert on the main branch - it will cause problems. I think you should reset this branch to match our current main. (Disable branch protection, sync branch.)

Merge main into rama_mathias - resolved conflicts	modified:   scenes/ui_elements/dialogue/components/balloon.gd
	modified:   scenes/ui_elements/input_hints/movement_input_hints.tscn
	modified:   scenes/ui_elements/input_hints/repel_hint.tscn
	modified:   scenes/ui_elements/input_hints/throw_hint.tscn
	modified:   scenes/world_map/frays_end.tscn
@JuaniCargnel
Copy link
Contributor

Okay @wjt, all set. I updated the rama_mathias branch and then made a PR to the Org’s main branch so both are up to date... I hope I did everything right haha. If you can, I’d really appreciate it if you could confirm!

Also, I just want to clarify again that this PR we’re talking in should be rejected (or closed) since it was just a mistake.

Thanks a lot for your help!

@wjt
Copy link
Member

wjt commented Oct 24, 2025

Okay @wjt, all set. I updated the rama_mathias branch and then made a PR to the Org’s main branch so both are up to date... I hope I did everything right haha. If you can, I’d really appreciate it if you could confirm!

main...Game-Lab-5-0-UTP-Grupo-2-Equipo-1:threadbare:main is still incorrect. You need to reset main in the fork to match main in this repo.

The problematic commit is Game-Lab-5-0-UTP-Grupo-2-Equipo-1@fa6fe66

If you disable branch protection in the fork, you should be able to use the destructive "Discard X commits" option in the "Sync fork" menu:

image

Edit: just to clarify you should not use this option if there are any intentional changes by learners on the fork's main branch. It will discard any such changes.

After resetting main you'll need to rebase the 1 patch in the rama_mathias branch onto the new main

@wjt
Copy link
Member

wjt commented Oct 24, 2025

Also, I just want to clarify again that this PR we’re talking in should be rejected (or closed) since it was just a mistake.

OK!

@wjt wjt closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

StoryQuest New StoryQuests or updates to existing ones

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants