Skip to content

fix(issuer): Increment ID when batch issuing #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
josipbagaric wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(issuer): Increment ID when batch issuing #3344

josipbagaric wants to merge 1 commit into from

Conversation

@josipbagaric
Copy link
Contributor

@josipbagaric josipbagaric commented Mar 17, 2022

Screen Shot 2022-03-17 at 17 13 45
.

@josipbagaric
fix(issuer): Increment ID when batch issuing
a019b10 
Fixes an issue where after a batch issuance, the ID field is not incremented.
@josipbagaric josipbagaric added the bug Something isn't working label Mar 17, 2022
@josipbagaric josipbagaric self-assigned this Mar 17, 2022
soanvig
soanvig approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@soanvig soanvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that we haven't encountered this problem in any practical matter.

I will take over test, so wait for commit @josipbagaric :)

@soanvig
Copy link
Contributor

soanvig commented Mar 18, 2022

OK I know why we haven't encountered that. So we use issueBatch from Issuer contract which does everything through certification request and approval. If we used issueBatch from Registry, then we would have a problem

@josipbagaric
Copy link
Contributor Author

josipbagaric commented Mar 18, 2022 •
edited
Loading

OK I know why we haven't encountered that. So we use issueBatch from Issuer contract which does everything through certification request and approval. If we used issueBatch from Registry, then we would have a problem

issueBatch() from the Issuer.sol uses issueBatchMultiple() from RegistryExtended.sol instead of issueBatch(). That's why it's never used.

@josipbagaric
Copy link
Contributor Author

josipbagaric commented Mar 18, 2022

Feel free to add a test to this branch and merge this whenever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soanvig soanvig soanvig approved these changes

@dwojno dwojno dwojno approved these changes

@knzeng-e knzeng-e Awaiting requested review from knzeng-e

+1 more reviewer

@JonaszJestem JonaszJestem JonaszJestem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@josipbagaric josipbagaric

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josipbagaric @soanvig @JonaszJestem @dwojno