Rollback on reorg v2 #782
Rollback on reorg v2 #782
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| | Some(_) => // Since the DC is registered by an earlier item in the query | ||
| // FIXME: This unsafely relies on the asc order of the items | ||
| // which is 99% true, but there were cases when the source ordering was wrong | ||
| false |
There was a problem hiding this comment.
Maybe add an assertion if possible or handle it so that there is no UB
| // Currently history update table uses S.object with transformation for schema, | ||
| // which is being lossed during conversion to dbSchema. | ||
| // So use simple insert values for now. | ||
| let isHistoryUpdate = table.tableName->Js.String2.startsWith("envio_history_") |
There was a problem hiding this comment.
Can you rather make this an api on the table?
| let getSafeCheckpointId = (safeCheckpointTracking: t, ~sourceBlockNumber: int) => { | ||
| let safeBlockNumber = sourceBlockNumber - safeCheckpointTracking.maxReorgDepth | ||
|
|
||
| if safeCheckpointTracking.checkpointBlockNumbers->Belt.Array.getUnsafe(0) > safeBlockNumber { |
| switch await Db.sql->InternalTable.Checkpoints.getRollbackTargetCheckpoint( | ||
| ~pgSchema=Env.Db.publicSchema, | ||
| ~reorgChainId, | ||
| ~lastKnownValidBlockNumber, | ||
| ) { | ||
| | [checkpoint] => checkpoint["id"] | ||
| | _ => 0 | ||
| } |
There was a problem hiding this comment.
would put this switch inside the function
2 participants
No description provided.