Skip to content

Conversation

zmiklank
Copy link
Contributor

No description provided.

barchw and others added 2 commits August 18, 2025 15:06
…ewrite and matching (#39169)

Adds support for matching requests that include the `*` character in the
path. A relevant issue was created:
envoyproxy/envoy#39168
Risk Level:
Testing: Updated unit tests
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk

Resolves: envoyproxy/envoy#39168

---------

Signed-off-by: Chwila <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
Backport #39310 and #39349

If a connection starts draining while it has negative unused capacity
(which happens if a SETTINGS frame reduces allowed concurrency to below
the current number of requests), that connections unused capacity will
be included in total pool capacity even though it is unusable because it
is draining. This can result in not enough connections being established
for current pending requests.

This is most problematic for long-lived requests (such as streaming gRPC
requests or long-poll requests) because a connection could be in the
draining state for a long time.

Maybe fixes: #39238

Fixed an issue that could lead to too many connections when using
:ref:`AutoHttpConfig

<envoy_v3_api_msg_extensions.upstreams.http.v3.HttpProtocolOptions.AutoHttpConfig>`
if the
established connection is ``http/2`` and Envoy predicted it would have
lower concurrent capacity.

---------

Signed-off-by: Greg Greenway <[email protected]>
@zmiklank
Copy link
Contributor Author

The CI seems to be broken. I created empty PR and the build fails with the same error: #344.
I tested these changes locally and the build was successful and all tests passed (except for notorious //test/extensions/filters/listener/original_dst:original_dst_integration_test).

@dcillera dcillera self-requested a review August 19, 2025 07:31
krinkinmu and others added 7 commits August 19, 2025 09:34
Commit Message:
Tests were somewhat non-deterministic in the sense that the
lines of code that this test exercises depend on the environment and
whether /sys/fs/cgroup/cpu/cpuacct.usage exists.

This issue affected Envoy coverage tests when we tried to migrate them
from Google RBE backend to EngFlow. The same test worked fine and
produced 100% coverage for LinuxContainerCpuStatsReader on Google RBE
backends, but when we migrated to EngFlow the coverage changed and
triggered a coverage test failure.

This PR refactors the test a bit to make sure that both CPU allocation
CPU times files are always available and valid, unless the test
explicitly overrides it.

Signed-off-by: Mikhail Krinkin <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
…vels (#40011)

Cherry-pick of envoyproxy/envoy#39954

PR to fix envoyproxy/envoy#39142 for 1.34
branch

On strict dns / logical dns resolutions if there are errors on the DNS
resolution, the failure logs are getting written only when debug log
level enabled and general logs are also in debug level. So, making the
general/success logs in the trace level to suppress the general logs
when user wants only error logs.

Signed-off-by: kishor7007 <[email protected]>
…s (#39615)

Can be disabled by setting
``envoy.restart_features.do_not_validate_http3_pseudo_headers`` to
false.

---------

Signed-off-by: Ryan Hamilton <[email protected]>
If tls connection data was queried before it was available, and empty
value was being incorrectly cached, preventing later calls from getting
the correct value.

One way this could be triggered was with an access log entry being
emitted before the TLS peer certificate was received during the TLS
handshake, which can be configured with tcp_proxy.

Fixes #40137

Signed-off-by: Greg Greenway <[email protected]>
Commit Message: Backport #40220 
Additional Description:
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:] 
[Optional Fixes #37983]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

Signed-off-by: Gerhard Stöbich <[email protected]>
Signed-off-by: Joao Grassi <[email protected]>
Co-authored-by: Gerhard Stöbich <[email protected]>
Backport fix for #40085

Signed-off-by: Greg Greenway <[email protected]>
@zmiklank zmiklank force-pushed the cherry-pick-1.26.3 branch from 16e975b to 9592c53 Compare August 19, 2025 07:38
Copy link
Contributor

@dcillera dcillera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks good to me.

@zmiklank zmiklank merged commit bfe0463 into envoyproxy:release/v1.34 Aug 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants