Backport: router: fix a bug where header mutations may not be processed properly (#40856) #40904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envoyproxy#40856) Commit Message: router: fix a bug where header mutations may not be processed properly Additional Description: The envoyproxy#39534 introduced a bug where the `response_headers_to_add`` may be processed multiple times for local responses from the router filter. The sendLocalReply method will call the `finalizeResponseHeaders()` and the envoyproxy#39534 updated the code and make the `finalizeResponseHeaders()` be called in the modify_headers_ callback. This finally resulted in this problem. Risk Level: low. Testing: integration. Docs Changes: n/a. Release Notes: added. Platform Specific Features: n/a. Signed-off-by: WangBaiping <[email protected]>
Member
Author
|
/backport |
repokitteh-read-only
bot
added
the
backport/review
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
|
seems like the release branches are also being hit with the go issue we fixed on main |
Member
Author
What should I do to fix it? 🤣 |
Member
|
we will need to backport the fix first ... i can raise a pr for this branch now ... |
Member
Author
Thanks. |
Signed-off-by: code <[email protected]>
Signed-off-by: code <[email protected]>
phlax
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: router: fix a bug where header mutations may not be processed properly
Additional Description:
The #39534 introduced a bug where the `response_headers_to_add`` may be processed multiple times for local responses from the router filter.
The sendLocalReply method will call the
finalizeResponseHeaders()and the #39534 updated the code and make thefinalizeResponseHeaders()be called in the modify_headers_ callback. This finally resulted in this problem.Risk Level: low.
Testing: integration.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.