[ProtoApiScrubber] Add directory skeleton and basic logic for field checker #41713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumit Kumar <[email protected]>
Signed-off-by: Sumit Kumar <[email protected]>
Signed-off-by: Sumit Kumar <[email protected]>
Signed-off-by: Sumit Kumar <[email protected]>
Signed-off-by: Sumit Kumar <[email protected]>
Signed-off-by: Sumit Kumar <[email protected]>
sumitkmr2
changed the title
sumitkmr2
commented
Oct 28, 2025
| ], | ||
| deps = [ | ||
| "//source/common/protobuf", | ||
| "@com_google_protoprocessinglib//proto_processing_lib/proto_scrubber", |
Contributor
Author
There was a problem hiding this comment.
This dependency is added for the classes FieldCheckerInterface, FieldCheckResults, etc.
Contributor
Author
|
Note that the Prechecks and Checks failure are not related to this change. Possibly transient failures in a different filter. |
Contributor
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add directory skeleton and basic logic for field checker
Additional Description: Add dummy implementation of overridden methods of FieldChecker. Subsequent PRs will add incremental functionality including:
Risk Level: None
Testing: UTs added just for coverage POV for now. UTs will be added incrementally per PR as per the functionality added.
Docs Changes: None
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]