Skip to content

Conversation

@antoniovleonti
Copy link
Contributor

Commit Message: ext_authz: add knob enforce_response_header_limits
Additional Description:

This PR adds a config knob to enable / disable the behavior of the ext authz filter dropping headers after the response header map limits have been reached.

This allows you to enable the behavior if you are using an untrusted external auth service (providing protection against adding too many headers) or disable the behavior if you trust the service.

Risk Level: low
Testing: unit tests added
Release Notes: added

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #41742 was opened by antoniovleonti.

see: more, trace.

@antoniovleonti
Copy link
Contributor Author

should this be a feature flag instead of a config? it seems like I am adding a config that is insecure by default to guard a security enhancement

Signed-off-by: antoniovleonti <[email protected]>
@antoniovleonti
Copy link
Contributor Author

should this be a feature flag instead of a config? it seems like I am adding a config that is insecure by default to guard a security enhancement

Counter argument: in a use case where the ext authz service is trusted it may always be valid to disable this check (since you know the CheckResponse won't contain an "unreasonable" amount of response headers)

OTOH there is no equivalent knob in ext_proc nor in the request path.

Signed-off-by: antoniovleonti <[email protected]>
@antoniovleonti
Copy link
Contributor Author

/assign @tyxia

@repokitteh-read-only repokitteh-read-only bot removed the api label Nov 1, 2025
@mattklein123 mattklein123 merged commit a48b7be into envoyproxy:main Nov 1, 2025
25 checks passed
@antoniovleonti antoniovleonti deleted the ext-authz-header-knob branch November 3, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants