Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41746 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 28, 2025
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #41746 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 force-pushed the update-xds branch 26 times, most recently from 647740c to e38bfc2 Compare October 29, 2025 22:42
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #41746 was synchronize by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 force-pushed the update-xds branch 3 times, most recently from 97d60a1 to 7a5be14 Compare October 31, 2025 10:16
@abeyad abeyad removed their assignment Oct 31, 2025
@mmorel-35 mmorel-35 force-pushed the update-xds branch 2 times, most recently from fd0e4ae to 123f942 Compare October 31, 2025 19:26
@mmorel-35 mmorel-35 marked this pull request as ready for review October 31, 2025 19:27
@mmorel-35 mmorel-35 force-pushed the update-xds branch 3 times, most recently from c30e572 to 5d25aff Compare November 1, 2025 21:24
Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 2, 2025
@agrawroh
Copy link
Member

agrawroh commented Nov 2, 2025

cc @phlax Could you PTAL as well?

Signed-off-by: Matthieu MOREL <[email protected]>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@phlax phlax merged commit 2737c7d into envoyproxy:main Nov 6, 2025
25 checks passed
@mmorel-35 mmorel-35 deleted the update-xds branch November 6, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants