access_logger: add new logger to record metrics derived from substitution formatter values #41770

ggreenway · 2025-10-29T22:38:55Z

Commit Message: Added a new access logger which emits configurable metrics.
Risk Level: Low
Testing: New tests added
Docs Changes: Docs in new proto
Release Notes: added
Platform Specific Features: None
Fixes #34168

Signed-off-by: Greg Greenway <[email protected]>

repokitteh-read-only · 2025-10-29T22:39:01Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41770 was opened by ggreenway.

see: more, trace.

repokitteh-read-only · 2025-10-29T22:39:06Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #41770 was opened by ggreenway.

see: more, trace.

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto

Signed-off-by: Greg Greenway <[email protected]>

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto

api/envoy/extensions/access_loggers/stats/v3/stats.proto

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto

Signed-off-by: Greg Greenway <[email protected]>

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto

api/envoy/extensions/access_loggers/stats/v3/stats.proto

Signed-off-by: Greg Greenway <[email protected]>

api/envoy/extensions/access_loggers/stats/v3/stats.proto

Signed-off-by: Greg Greenway <[email protected]>

ggreenway · 2025-10-31T01:10:11Z

Starting to add some implementation. Completely untested so far. I think I'm doing the StatName storage correctly, but please take a look and let me know.

wbpcode

Thanks for this great contribution. Some initial comments to the API are added.

api/envoy/extensions/access_loggers/stats/v3/stats.proto

Signed-off-by: Greg Greenway <[email protected]>

ggreenway · 2025-11-06T01:34:18Z

/coverage

repokitteh-read-only · 2025-11-06T01:34:24Z

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-cncf-pr/41770/coverage/index.html

For comparison, current coverage on main branch is here:

https://storage.googleapis.com/envoy-cncf-postsubmit/main/coverage/index.html

The coverage results are (re-)rendered each time the CI Envoy/Checks (coverage) job completes.

🐱

Caused by: a #41770 (comment) was created by @ggreenway.

see: more, trace.

ggreenway · 2025-11-06T01:37:31Z

@wbpcode @kyessenov tests and docs are written. This is now fully ready for review.

api/envoy/extensions/access_loggers/stats/v3/stats.proto

source/extensions/extensions_metadata.yaml

source/extensions/access_loggers/stats/stats.cc

kyessenov · 2025-11-06T19:48:47Z

source/extensions/access_loggers/stats/stats.cc

+        getFormatValue(*histogram.value_formatter_, context, stream_info,
+                       histogram.unit_ == Stats::Histogram::Unit::Percent);
+    if (!computed_value_opt.has_value()) {
+      continue;


Might be useful to add a failure stat? Given we log, not necessary though.

test/extensions/access_loggers/stats/stats_test.cc

test/extensions/access_loggers/stats/integration_test.cc

kyessenov · 2025-11-06T20:01:02Z

LGTM and some feedback. Nothing that can't be fixed later though.

Signed-off-by: Greg Greenway <[email protected]>

kyessenov

Thank you!

ggreenway · 2025-11-08T01:25:32Z

/retest

ggreenway · 2025-11-08T01:26:13Z

@wbpcode or @adisuissa this needs an API signoff

wbpcode

/lgtm api

wbpcode · 2025-11-08T11:23:25Z

@ggreenway Thanks so much for this PR. This will be a huge change for our users/stats system. 👍

wbpcode

Code also LGTM. Thanks.

wbpcode · 2025-11-08T11:36:27Z

I think it would be better to have a detailed document/example to show how it works. But it needn't to be done in this PR anyway.

adisuissa

Thanks overal LGTM.
On thing I suggest clarifying is what happens if there's a conflict between header0set stat name and one that Envoy already has.
/lgtm api

I suggest adding an example showing how to use this extension (either in the api or accompanying doc).

ggreenway · 2025-11-10T17:57:07Z

/retest

kyessenov · 2025-11-10T17:59:08Z

We could example in a follow-up and close some open stats issue, e.g. #33671 or the one mentioned in #41732.

http: add new filter to record request timing stats

4bac0aa

Signed-off-by: Greg Greenway <[email protected]>

repokitteh-read-only bot added the api label Oct 29, 2025

repokitteh-read-only bot assigned adisuissa Oct 29, 2025

ggreenway mentioned this pull request Oct 29, 2025

Export Common Duration Metrics #34168

Closed

wbpcode reviewed Oct 30, 2025

View reviewed changes

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto Show resolved Hide resolved

new version

70780d5

Signed-off-by: Greg Greenway <[email protected]>

kyessenov reviewed Oct 30, 2025

View reviewed changes

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto Outdated Show resolved Hide resolved

kyessenov reviewed Oct 30, 2025

View reviewed changes

api/envoy/extensions/access_loggers/stats/v3/stats.proto Outdated Show resolved Hide resolved

kyessenov reviewed Oct 30, 2025

View reviewed changes

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto Outdated Show resolved Hide resolved

map->list

eb5bf13

Signed-off-by: Greg Greenway <[email protected]>

kyessenov reviewed Oct 30, 2025

View reviewed changes

api/envoy/extensions/filters/http/timing_stats/v3/timing_stats.proto Outdated Show resolved Hide resolved

kyessenov reviewed Oct 30, 2025

View reviewed changes

api/envoy/extensions/access_loggers/stats/v3/stats.proto Outdated Show resolved Hide resolved

ggreenway added 4 commits October 30, 2025 10:57

remove duration

5e26f96

Signed-off-by: Greg Greenway <[email protected]>

add fixed value option

4e007d8

Signed-off-by: Greg Greenway <[email protected]>

extension formatters

1612f76

Signed-off-by: Greg Greenway <[email protected]>

move

8ac56c6

Signed-off-by: Greg Greenway <[email protected]>

ggreenway changed the title ~~http: add new filter to record request timing stats~~ access_logger: add new logger to record metrics derived from substitution formatter values Oct 30, 2025

fix BUILDs

7e3bdf4

Signed-off-by: Greg Greenway <[email protected]>

TAOXUY reviewed Oct 30, 2025

View reviewed changes

api/envoy/extensions/access_loggers/stats/v3/stats.proto Show resolved Hide resolved

ggreenway added 2 commits October 30, 2025 12:27

format; remove Event type in favor of fixed increaes value

d879a14

Signed-off-by: Greg Greenway <[email protected]>

add more histogram units; move enum

84a8073

Signed-off-by: Greg Greenway <[email protected]>

kyessenov mentioned this pull request Oct 30, 2025

stats: add UpDownCounter #41785

Open

Starting to implement

aa9c227

Signed-off-by: Greg Greenway <[email protected]>

wbpcode reviewed Oct 31, 2025

View reviewed changes

wbpcode self-assigned this Oct 31, 2025

ggreenway added 2 commits November 1, 2025 13:37

iterate on API

77a9430

Signed-off-by: Greg Greenway <[email protected]>

implement latest version of api

963417e

Signed-off-by: Greg Greenway <[email protected]>

ggreenway added 8 commits November 5, 2025 07:44

Merge remote-tracking branch 'upstream/main' into timing_stats

f37fa81

move unit and add implementation for it

acc1ff6

Signed-off-by: Greg Greenway <[email protected]>

cleanup includes

cf9fda4

Signed-off-by: Greg Greenway <[email protected]>

convert integration test config to yaml for readability

fabc985

Signed-off-by: Greg Greenway <[email protected]>

add more docs

074a326

Signed-off-by: Greg Greenway <[email protected]>

format

7970417

Signed-off-by: Greg Greenway <[email protected]>

add tests, fixes

497787c

Signed-off-by: Greg Greenway <[email protected]>

release note

ce0bfb8

Signed-off-by: Greg Greenway <[email protected]>

kyessenov previously approved these changes Nov 6, 2025

View reviewed changes

fixes

29bb77a

Signed-off-by: Greg Greenway <[email protected]>

ggreenway dismissed kyessenov’s stale review via 29bb77a November 7, 2025 05:41

kyessenov approved these changes Nov 7, 2025

View reviewed changes

wbpcode reviewed Nov 8, 2025

View reviewed changes

repokitteh-read-only bot removed the api label Nov 8, 2025

wbpcode approved these changes Nov 8, 2025

View reviewed changes

adisuissa reviewed Nov 10, 2025

View reviewed changes

ggreenway enabled auto-merge (squash) November 10, 2025 17:57

Merge remote-tracking branch 'upstream/main' into timing_stats

732267f

ggreenway merged commit ac08f4e into envoyproxy:main Nov 10, 2025
26 checks passed

kyessenov mentioned this pull request Nov 19, 2025

New extension: access log based metrics #30619

Closed

access_logger: add new logger to record metrics derived from substitution formatter values #41770

access_logger: add new logger to record metrics derived from substitution formatter values #41770

Uh oh!

Conversation

ggreenway commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Oct 29, 2025

Uh oh!

repokitteh-read-only bot commented Oct 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggreenway commented Oct 31, 2025

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggreenway commented Nov 6, 2025

Uh oh!

repokitteh-read-only bot commented Nov 6, 2025

Uh oh!

ggreenway commented Nov 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyessenov Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kyessenov commented Nov 6, 2025

Uh oh!

kyessenov left a comment

Choose a reason for hiding this comment

Uh oh!

ggreenway commented Nov 8, 2025

Uh oh!

ggreenway commented Nov 8, 2025

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

wbpcode commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

wbpcode commented Nov 8, 2025

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

ggreenway commented Nov 10, 2025

Uh oh!

kyessenov commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

ggreenway commented Oct 29, 2025 •

edited

Loading

wbpcode commented Nov 8, 2025 •

edited

Loading