lua: Add counter tracking number of executions #41772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… execution count. Signed-off-by: Anirban Nandi <[email protected]>
Contributor
Author
|
ping @wbpcode could you PTAL? TIA |
wbpcode
previously approved these changes
Nov 8, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Could you merge main and resolve the conflict? Thanks.
Signed-off-by: code <[email protected]>
Member
|
Hah, I resolved the conflict by myself, let's waiting for the CI to pass. |
Contributor
Author
|
@wbpcode is this good to merge now? |
agrawroh
approved these changes
Nov 9, 2025
Member
|
Will wait for @wbpcode to take a final look and merge. |
Member
|
Sorry for the delay. I was coding coding and coding in the last few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: lua: Add counter tracking number of executions
Additional Description:
This PR adds a new counter stat (
executions) to the Lua filter. This is helpful in the case of multiple distributed envoy instances (e.g. a service mesh like Istio) where users (and even mesh owners) can use this metric to identify whether the intent was correctly propagated to the proxy as well as correctly configured in the filter chain by tracking changes with each traffic passing through the proxy. Also, this, when coupled with the existingerrorscounter, can provide the number of successful executions as well.Risk Level: Low
Testing: Unit tests, integration tests and manual tests
Docs Changes: Updated
lua_filter.rstRelease Notes: Added to
changelogs/current.yamlPlatform Specific Features: N/A