Move UseClientProtocol to ClusterSettings

[jukie]

What type of PR is this?

What this PR does / why we need it:
Moves UseClientProtocol to ClusterSettings for use with ext Auth and ext Proc
Which issue(s) this PR fixes:

Fixes #7310

Release Notes: No

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.02%. Comparing base (f133f5e) to head (39b6d34).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7347      +/-   ##
==========================================
- Coverage   72.06%   72.02%   -0.05%     
==========================================
  Files         230      230              
  Lines       33404    33404              
==========================================
- Hits        24074    24059      -15     
- Misses       7583     7596      +13     
- Partials     1747     1749       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[arkodg]

thanks for picking this one up @jukie, doesnt this need some more plumbing in gateway-api layer and xds layer as well ?
can we add test YAMLs to confirm this works

[jukie]

@arkodg it's an inline field so no changes necessary. We already have testdata that makes use of useClientProtocol both in internal/xds/translator/testdata and internal/gatewayapi/testdata

• https://github.com/jukie/gateway/blob/a48d3ba8d3ff1749f26da45ccf134fdb4ef40e53/internal/xds/translator/testdata/out/xds-ir/http-preserve-client-protocol.clusters.yaml#L28
• https://github.com/jukie/gateway/blob/a48d3ba8d3ff1749f26da45ccf134fdb4ef40e53/internal/gatewayapi/testdata/backendtrafficpolicy-use-client-protocol.out.yaml#L196

[jukie]

/retest

[arkodg]

thanks, asked because I did a quick search and saw some special handling here

gateway/internal/gatewayapi/backendtrafficpolicy.go

Line 543 in ee4ae71

r.UseClientProtocol = policy.Spec.UseClientProtocol

[jukie]

That should be covered by the existing testdata right? Let me know if there's any case that isn't and I can add more testdata.

ClusterSettings is added inline so any refs to btp.Spec.UseClientProtocol continue working without any changes necessary.

[jukie]

/retest

[jukie]

/retest

[arkodg]

checked again and this isnt going to work, the IR field needs to change as well

gateway/internal/xds/translator/cluster.go

Line 1227 in f133f5e

useClientProtocol: ptr.Deref(httpRoute.UseClientProtocol, false),

also this may need to be tested e2e to make sure that the protocol of downstream request can impact ext auth protocol type

[jukie]

I'm not following, what needs to change in the IR field? If that was broken the existing testdata would be failing here. I think the follow-up PR would be for actually using it within ext auth, etc but moving into cluster settings is the first piece.

Or are you suggesting doing both here?

[arkodg]

ah I wasn't aware this was part of the fix, if we do it in parts, it gets tricky because we cannot add a notImplementedHide marker for this