This repository was archived by the owner on Mar 6, 2024. It is now read-only.
expand test matrix to windows, macos and pypy-37 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2021
|
Thanks for the PR! I will take a look at the timeout issue with |
|
Hooray, thanks again!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for
nest_asyncio!This expands the test matrix to include the windows and macos platforms, as well as adding pypy-3.7.
The good news is it appears to work! 🎉
The bad news is it isn't helping me unravel my downstream issues:
It looks like we're running into some issues around
selecton anEPollSelector:https://github.com/jupyter/jupyter_client/pull/663/checks?check_run_id=2954120077#step:6:1033
I'll do some more looking, but starting from a 🟢 upstream is good!
Thanks again!