-
Notifications
You must be signed in to change notification settings - Fork 64
Add clang_tidy_test #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One interesting difference with the test is it runs over multiple files at once, potentially only invoking clang-tidy once per library, but it will invoke it twice if there is a C file and C++ file |
im actually not sure if this is good or bad since clang-tidy seems to not run in parallel and is quite slow. but users can always make 1 test target per file if they'd prefer. |
This is a new test rule that executes clang-tidy as a test via shell script instead of an aspect. The biggest implementation issue with this is that the paths you get from CcInfo do not match the directory structure when running clang-tidy in a test. This requires a bit of fixing up. This attempts to share as much logic as possible with the aspect. I think a bit more could be shared in the future. Based on erenon#65 Closes: erenon#65 Fixes: erenon#15
99dd2c6
to
5e07a7b
Compare
added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the high quality contribution!
This reverts commit 18b83b8.
requires ci fix: #86 |
Thanks, merged! |
thanks! sorry i should have squashed here, I assumed that would happen at merge time |
This is a new test rule that executes clang-tidy as a test via shell
script instead of an aspect.
The biggest implementation issue with this is that the paths you get
from CcInfo do not match the directory structure when running clang-tidy
in a test. This requires a bit of fixing up.
This attempts to share as much logic as possible with the aspect. I
think a bit more could be shared in the future.
Based on #65
Closes: #65
Fixes: #15