erl_expand_records - add specs #10045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 97 suites 1h 6m 36s ⏱️ Results for commit 12e0ff7. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
ilya-klyuchnikov
force-pushed
the
erl_expand_records_specs
branch
2 times, most recently
from
ce4945c to
d48c0c3
Compare
ilya-klyuchnikov
force-pushed
the
erl_expand_records_specs
branch
from
d48c0c3 to
dc43b04
Compare
ilya-klyuchnikov
force-pushed
the
erl_expand_records_specs
branch
from
dc43b04 to
fd5faae
Compare
ilya-klyuchnikov
force-pushed
the
erl_expand_records_specs
branch
from
fd5faae to
12e0ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specs.
The module has 6 functions that operate both on expressions and patterns - translating expressions to expressions and patterns to patterns respectively. While logically those specs are correct, they go against dialyzer's view/requirement that overloaded contracts should not have overlapping domains, - suppressing such dialyzer errors explicitly.
(otherwise the specs would be too sloppy).