Skip to content

Conversation

@kvakvs
Copy link
Collaborator

@kvakvs kvakvs commented Aug 4, 2025

Mnesia

Summary of changes

slave is removed from comments and private APIs as a unwelcome word.
New word is used for this, follower

As slave module is also deprecated, usage of slave:start in the tests is updated to peer:start

@kvakvs kvakvs added the testing currently being tested, tag is used by OTP internal CI label Aug 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

CT Test Results

  2 files   61 suites   19m 7s ⏱️
693 tests 542 ✅ 151 💤 0 ❌
748 runs  582 ✅ 166 💤 0 ❌

Results for commit bd32906.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kvakvs kvakvs requested a review from dgud August 6, 2025 13:15
@kvakvs kvakvs self-assigned this Aug 6, 2025
@kvakvs kvakvs added the team:PS Assigned to OTP team PS label Aug 6, 2025
dgud
dgud previously approved these changes Aug 6, 2025
@kvakvs kvakvs added testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Aug 20, 2025
@kvakvs kvakvs force-pushed the eimytdl/slave-to-peer-mnesia/OTP-19720 branch from ad7b756 to 4d8b929 Compare August 25, 2025 13:15
@CLAassistant
Copy link

CLAassistant commented Aug 25, 2025

CLA assistant check
All committers have signed the CLA.

@kvakvs
Copy link
Collaborator Author

kvakvs commented Aug 25, 2025

Changed email to OTP email, force pushed, this will break the testing tag so i'm doing the procedure of resetting the tag

@kvakvs kvakvs removed the testing currently being tested, tag is used by OTP internal CI label Aug 25, 2025
@IngelaAndin
Copy link
Contributor

@kvakvs, @dgud although the use of follower in this PR is not in any API documentation and therefore maybe not contributing to confusion in the same way as in #10128 I think we should change it here too to be consistent.

Copy link
Contributor

@IngelaAndin IngelaAndin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in main PR

@kvakvs kvakvs force-pushed the eimytdl/slave-to-peer-mnesia/OTP-19720 branch from bd32906 to 44762f1 Compare September 3, 2025 11:38
@IngelaAndin IngelaAndin changed the title [mnesia] Slave module deprecation: Replace slave to follower in code and comments [mnesia] Slave module deprecation: Replace slave to peer in code and comments Sep 3, 2025
@kvakvs kvakvs merged commit dcded5d into erlang:maint Sep 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:PS Assigned to OTP team PS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants