Skip to content

erts: fix static function prototypes #9983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: maint
Choose a base branch
from
Open

erts: fix static function prototypes #9983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions erts/emulator/test/nif_SUITE_data/nif_SUITE.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3765,9 +3765,9 @@ static ERL_NIF_TERM ioq(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
return enif_make_badarg(env);
}

static ERL_NIF_TERM make_bool(ErlNifEnv* env, int bool)
static ERL_NIF_TERM make_bool(ErlNifEnv* env, int boolean)
{
return bool ? atom_true : atom_false;
return boolean ? atom_true : atom_false;
}

static ERL_NIF_TERM get_local_pid_nif(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
Expand Down
12 changes: 6 additions & 6 deletions erts/emulator/test/port_SUITE_data/port_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ typedef struct {

PORT_TEST_DATA* port_data;

static int packet_loop();
static void reply();
static void write_reply();
static void ensure_buf_big_enough();
static int readn();
static int packet_loop(void);
static void reply(char *buf, int size);
static void write_reply(char *buf, int size);
static void ensure_buf_big_enough(int size);
static int readn(int fd, unsigned char *buf, int len);
static void delay(unsigned ms);
static void dump(unsigned char* buf, int sz, int max);
static void replace_stdout(char* filename);
Expand Down Expand Up @@ -212,7 +212,7 @@ int main(int argc, char *argv[])
replace_stdout(port_data->output_file);

if (port_data->fd_count)
reply(&fd_count, sizeof(fd_count));
reply((char *) &fd_count, sizeof(fd_count));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be not a good idea. Any thought ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what reply expects, so let's not change anything here.


if (port_data->no_packet_loop){
free(port_data);
Expand Down
10 changes: 5 additions & 5 deletions erts/emulator/test/port_bif_SUITE_data/port_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ typedef struct {

PORT_TEST_DATA* port_data;

static int packet_loop();
static void reply();
static void write_reply();
static void ensure_buf_big_enough();
static int readn();
static int packet_loop(void);
static void reply(char *buf, int size);
static void write_reply(char *buf, int size);
static void ensure_buf_big_enough(int size);
static int readn(int fd, unsigned char *buf, int len);
static void delay(unsigned ms);
static void dump(unsigned char* buf, int sz, int max);
static void replace_stdout(char* filename);
Expand Down
Loading