Skip to content

gitter: Fix occupants for GitterRoom #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gitter: Fix occupants for GitterRoom #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions gitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,22 @@ def topic(self):
else:
raise RoomNotFoundError("Cannot find the room '{}'".format(self.uri))

def _user_count(self):
json_rooms = self._backend.readAPIRequest('rooms')
for json_room in json_rooms:
if json_room['id'] is self.idd:
return json_room['userCount']

@property
def occupants(self):
occupants = []
json_users = self._backend.readAPIRequest('rooms/%s/users' % self._idd)
for json_user in json_users:
occupants.append(GitterRoomOccupant.build_from_json(self, json_user))
user_count = self._user_count()
for skip in range(0, user_count, 100):
# 100 is the maximum number of users Gitter API can return.
json_users = self._backend.readAPIRequest(
'rooms/%s/users?skip={}?limit={}'.format(self.idd, skip, 100))
for json_user in json_users:
occupants.append(GitterRoomOccupant.build_from_json(self, json_user))
return occupants

def __eq_(self, other):
Expand Down