Skip to content

Conversation

lbillinghamwrk
Copy link

Should fix issue #1721.

webtest is used to validate incoming webhooks in the production Webserver().

Via webtest and webob, we have a transitive dependency on cgi.
As of python 3.13 cgi has been dropped from stdlib.

The recommended stopgap is to add an explicit dependency on legacy-cgi,
long term webob should be replaced with WSGI or ASGI

Should fix issue
[errbotio#1721](errbotio#1721).

`webtest` is used to validate incomming webhooks
in the production Webserver().

Via `webtest` and `webob`,
we have a transitive dependency on `cgi`.
As of python 3.13 [`cgi` has been dropped from stdlib](https://docs.python.org/3/deprecations/pending-removal-in-3.13.html).
@lbillinghamwrk lbillinghamwrk marked this pull request as ready for review May 27, 2025 17:05
@lbillinghamwrk
Copy link
Author

I'm not 100% sure that setup.py is compatible with PEP 508 environment markers.
Pending a full test-suite workflow approval, I've tested that python -m pip install . works in both python 3.9 and 3.13.
Only the latter, as expected, has legacy-cgi present.

kindermannlennart added a commit to Hapag-Lloyd/errbot that referenced this pull request Aug 15, 2025
<!--- yamllint disable rule:single-title/single-h1 -->

# Description

webtest is used to validate incoming webhooks in the production
Webserver().

Via webtest and webob, we have a transitive dependency on cgi.
As of python 3.13 [cgi has been dropped from
stdlib](https://docs.python.org/3/deprecations/pending-removal-in-3.13.html).

The recommended stopgap is to add an explicit dependency on legacy-cgi,
long term webob should be replaced with WSGI or ASGI

See: errbotio#1729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant