Fix it so that --check-app-descriptor can actually be turned off #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmarkov
force-pushed
the
fix-check-app-desc
branch
from
6c3cb8e to
b611374
Compare
ivmarkov
force-pushed
the
fix-check-app-desc
branch
from
b611374 to
751d4e9
Compare
|
This is probably a bit more complicated than necessary, see #932 |
|
... but is not a breaking change. Up to you, I'm fine either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject says it all.
I also took the liberty to sophisticate the flag documentation, because "Flag to check the app descriptor in bootloader" does not sound completely correct. The app descriptor struct is not in the bootloader image in the first place (it is in the app image), and the fact that newer IDF bootloaders want it is a whole separate topic.