Skip to content

Conversation

Forairaaaaa
Copy link

@Forairaaaaa Forairaaaaa commented Jul 1, 2025

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Add board M5Stack Tab5 support

@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 02:43
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the new M5Stack Tab5 board by introducing its board support package (BSP), example configurations, and documentation updates.

  • Introduce bsp/m5stack_tab5 directory with source, headers, Kconfig, CMakeLists, and license.
  • Add sdkconfig.bsp.m5stack_tab5 defconfig files across all examples.
  • Update build/CI scripts and README entries to include M5Stack Tab5.

Reviewed Changes

Copilot reviewed 28 out of 31 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
bsp/m5stack_tab5/ New BSP implementation and headers for M5Stack Tab5
examples/*/sdkconfig.bsp.m5stack_tab5 Add M5Stack Tab5 default configurations for all examples
SquareLine/boards/v9/m5stack_tab5/ Add SquareLine LVGL board definitions for M5Stack Tab5
README.md Register M5Stack Tab5 in main README table
.pre-commit-config.yaml Enable API docs generation for m5stack_tab5
.github/workflows/upload_component.yml Include m5stack_tab5 in component upload workflow
Comments suppressed due to low confidence (1)

bsp/m5stack_tab5/include/bsp/display.h:65

  • [nitpick] The struct name bsp_display_config_t is very similar to bsp_display_cfg_t in m5stack_tab5.h, which may confuse users—consider renaming one for consistency.
typedef struct {

@github-actions github-actions bot changed the title feat: Add board M5Stack Tab5 feat: Add board M5Stack Tab5 (BSP-692) Jul 1, 2025
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Forairaaaaa Thank you for add this board so quick! I made the first round of review and left some comments about API and documentation.
I didn't see *.c file yet. And didn't test it on HW yet.

Please, install pre-commit and use it: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/contribute/install-pre-commit-hook.html it will auto-generate lot of.

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I made next round of review, tried on HW and left some comments.
Now, compilation failed. Audio not tested yet.
Missing IMU and Camera, will be added later?

@espzav
Copy link
Collaborator

espzav commented Aug 11, 2025

Audio not tested yet.

Tried display_audio_photo example and audio not working - the wav not playing - only noise.

@espzav
Copy link
Collaborator

espzav commented Aug 28, 2025

Hi @Forairaaaaa, please, do you have any update on this?

@Forairaaaaa
Copy link
Author

Hi @Forairaaaaa, please, do you have any update on this?

Sorry, I'm tied up with another task at the moment.

@Forairaaaaa
Copy link
Author

Hi @espzav , I not sure how to add camera support yet, since csi camera requires esp-video , but the example is based on esp-camera.

@espzav
Copy link
Collaborator

espzav commented Sep 4, 2025

Hi @espzav , I not sure how to add camera support yet, since csi camera requires esp-video , but the example is based on esp-camera.

Hi @Forairaaaaa, I am working on new API and example for CSI cameras - I will add it to this BSP later.

@giobauermeister
Copy link

Does M5Stack Tab5 support hardware display rotation? I have tested this PR with my Tab5 and when using the screen in landscape mode and rotation in software by LVGL, the FPS gets really slow down to 6FPS when scrolling.

@georgik
Copy link
Contributor

georgik commented Sep 17, 2025

I've pushed expander into separate repo here:
https://github.com/georgik/esp-idf-component-io-expander-pi4ioe5v6408

Meanwhile somebody published pi4 expander, but in C++, it's not completely compatible: https://components.espressif.com/components/espp/pi4ioe5v/versions/1.0.24

@Forairaaaaa Please, consider pushing the expander repo to Component Registry under M5 Stack namespace.

@georgik
Copy link
Contributor

georgik commented Sep 17, 2025

Here's working example with SDL3 as graphical library on Tab5. Just NOGLIB selection was necessary to commit directly to BSP Code, since there is no way to override this setting from parent project or Kconfig.

https://github.com/georgik/esp-idf-component-SDL/tree/feature/sdl_bsp/examples/snow

idf.py -D SDKCONFIG_DEFAULTS="sdkconfig.defaults.m5stack_tab5" build flash monitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants