-
Notifications
You must be signed in to change notification settings - Fork 175
feat: Add board M5Stack Tab5 (BSP-692) #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add board M5Stack Tab5 (BSP-692) #593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for the new M5Stack Tab5 board by introducing its board support package (BSP), example configurations, and documentation updates.
- Introduce
bsp/m5stack_tab5
directory with source, headers, Kconfig, CMakeLists, and license. - Add
sdkconfig.bsp.m5stack_tab5
defconfig files across all examples. - Update build/CI scripts and README entries to include M5Stack Tab5.
Reviewed Changes
Copilot reviewed 28 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
bsp/m5stack_tab5/ | New BSP implementation and headers for M5Stack Tab5 |
examples/*/sdkconfig.bsp.m5stack_tab5 | Add M5Stack Tab5 default configurations for all examples |
SquareLine/boards/v9/m5stack_tab5/ | Add SquareLine LVGL board definitions for M5Stack Tab5 |
README.md | Register M5Stack Tab5 in main README table |
.pre-commit-config.yaml | Enable API docs generation for m5stack_tab5 |
.github/workflows/upload_component.yml | Include m5stack_tab5 in component upload workflow |
Comments suppressed due to low confidence (1)
bsp/m5stack_tab5/include/bsp/display.h:65
- [nitpick] The struct name
bsp_display_config_t
is very similar tobsp_display_cfg_t
in m5stack_tab5.h, which may confuse users—consider renaming one for consistency.
typedef struct {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Forairaaaaa Thank you for add this board so quick! I made the first round of review and left some comments about API and documentation.
I didn't see *.c
file yet. And didn't test it on HW yet.
Please, install pre-commit and use it: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/contribute/install-pre-commit-hook.html it will auto-generate lot of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I made next round of review, tried on HW and left some comments.
Now, compilation failed. Audio not tested yet.
Missing IMU and Camera, will be added later?
Tried |
Hi @Forairaaaaa, please, do you have any update on this? |
Sorry, I'm tied up with another task at the moment. |
Hi @espzav , I not sure how to add camera support yet, since csi camera requires |
Hi @Forairaaaaa, I am working on new API and example for CSI cameras - I will add it to this BSP later. |
Does M5Stack Tab5 support hardware display rotation? I have tested this PR with my Tab5 and when using the screen in landscape mode and rotation in software by LVGL, the FPS gets really slow down to 6FPS when scrolling. |
I've pushed expander into separate repo here: Meanwhile somebody published pi4 expander, but in C++, it's not completely compatible: https://components.espressif.com/components/espp/pi4ioe5v/versions/1.0.24 @Forairaaaaa Please, consider pushing the expander repo to Component Registry under M5 Stack namespace. |
Here's working example with SDL3 as graphical library on Tab5. Just NOGLIB selection was necessary to commit directly to BSP Code, since there is no way to override this setting from parent project or Kconfig. https://github.com/georgik/esp-idf-component-SDL/tree/feature/sdl_bsp/examples/snow
|
ESP-BSP Pull Request checklist
Change description
Add board M5Stack Tab5 support