Skip to content

Conversation

@isthaison
Copy link

@isthaison isthaison commented Sep 26, 2025

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Please describe your change here


Note

Bumps BSP version, updates esp_codec_dev to ^1.4.0, and refreshes LVGL benchmark data in README.

  • BSP/Config:
    • Bump bsp/esp32_p4_function_ev_board/idf_component.yml version from 5.0.1 to 5.0.2.
    • Update dependency esp_codec_dev from "1.2.*" to "^1.4.0".
  • Docs (bsp/esp32_p4_function_ev_board/README.md):
    • Update dependencies table to show esp_codec_dev ^1.4.0.
    • Refresh LVGL Benchmark: new date and adjusted metrics across multiple scenes.

Written by Cursor Bugbot for commit 8886f0f. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Update esp_codec_dev version to ^1.4.0 Update esp_codec_dev version to ^1.4.0 (BSP-719) Sep 26, 2025
@espzav
Copy link
Collaborator

espzav commented Sep 29, 2025

@isthaison thank you for this PR. Please update the BSP version - it will be automatically released to Component manager after merge this PR.

@isthaison
Copy link
Author

I got it

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isthaison Thank you! LGTM

@espzav
Copy link
Collaborator

espzav commented Sep 30, 2025

I got it

Thank you, please run pre-commit

@isthaison isthaison requested a review from espzav September 30, 2025 12:50
@isthaison
Copy link
Author

Thank you @espzav. Could you please double-check it once more?

@espzav
Copy link
Collaborator

espzav commented Oct 1, 2025

@isthaison When you install pre-commit (https://docs.espressif.com/projects/esp-idf/en/latest/esp32/contribute/install-pre-commit-hook.html) it will be solved automatically during commiting. Then you only add new changes made by pre-commit.

@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 15:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ESP32-P4 Function EV Board BSP to version 5.0.2 and upgrades the esp_codec_dev dependency to ^1.4.0 to address BSP-719.

  • Bumped BSP version from 5.0.1 to 5.0.2
  • Updated esp_codec_dev dependency from 1.2.* to ^1.4.0
  • Updated documentation to reflect new dependency version and refreshed benchmark data

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
bsp/esp32_p4_function_ev_board/idf_component.yml Updates BSP version and esp_codec_dev dependency version
bsp/esp32_p4_function_ev_board/README.md Updates documentation table and benchmark data to reflect dependency changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@isthaison isthaison requested a review from Copilot October 6, 2025 16:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@isthaison
Copy link
Author

Hi @espzav, Can you help me upgrade the package instead of maintaining this pull request?

@espzav
Copy link
Collaborator

espzav commented Oct 7, 2025

Hi @isthaison I am sorry about failing CI, we have some issues in other components now, we are working on it.
For manual change the version of esp_codec_dev, you can move related BSP from managed_components to components folder and change anything inside. It should work for any component.
I will continue with this PR, when we fix all CI issues. I apologize for this inconvinience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants