-
Notifications
You must be signed in to change notification settings - Fork 176
Update esp_codec_dev version to ^1.4.0 (BSP-719) #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@isthaison thank you for this PR. Please update the BSP version - it will be automatically released to Component manager after merge this PR. |
|
I got it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isthaison Thank you! LGTM
Thank you, please run pre-commit |
|
Thank you @espzav. Could you please double-check it once more? |
|
@isthaison When you install pre-commit (https://docs.espressif.com/projects/esp-idf/en/latest/esp32/contribute/install-pre-commit-hook.html) it will be solved automatically during commiting. Then you only add new changes made by pre-commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ESP32-P4 Function EV Board BSP to version 5.0.2 and upgrades the esp_codec_dev dependency to ^1.4.0 to address BSP-719.
- Bumped BSP version from 5.0.1 to 5.0.2
- Updated esp_codec_dev dependency from 1.2.* to ^1.4.0
- Updated documentation to reflect new dependency version and refreshed benchmark data
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bsp/esp32_p4_function_ev_board/idf_component.yml | Updates BSP version and esp_codec_dev dependency version |
| bsp/esp32_p4_function_ev_board/README.md | Updates documentation table and benchmark data to reflect dependency changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @espzav, Can you help me upgrade the package instead of maintaining this pull request? |
|
Hi @isthaison I am sorry about failing CI, we have some issues in other components now, we are working on it. |
ESP-BSP Pull Request checklist
Change description
Please describe your change here
Note
Bumps BSP version, updates esp_codec_dev to ^1.4.0, and refreshes LVGL benchmark data in README.
bsp/esp32_p4_function_ev_board/idf_component.ymlversionfrom5.0.1to5.0.2.esp_codec_devfrom"1.2.*"to"^1.4.0".bsp/esp32_p4_function_ev_board/README.md):esp_codec_dev^1.4.0.Written by Cursor Bugbot for commit 8886f0f. This will update automatically on new commits. Configure here.