Bsp/esp32 p4 eye #652
Merged
Bsp/esp32 p4 eye #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
from
ecb0ac9 to
bcba723
Compare
Test Results25 tests 25 ✅ 1m 8s ⏱️ Results for commit 92727bd. ♻️ This comment has been updated with latest results. |
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
5 times, most recently
from
dc4af7f to
a971833
Compare
|
@tore-espressif PTAL |
There was a problem hiding this comment.
@espzav thank you very much for this PR!
I left few comments/questions before I start the test on HW :)
|
@espzav I did not test the microphone, others LGTM |
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
from
a971833 to
2a7ac99
Compare
@tore-espressif Thank you for the review! I fixed some issues in generator. Others will be fixed soon.
|
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
2 times, most recently
from
94ac441 to
a25809b
Compare
3 tasks
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
9 times, most recently
from
ef1b23c to
7e84e5e
Compare
|
@tore-espressif Added SquareLine support. You can continue with review. Thank you |
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
2 times, most recently
from
d284987 to
d26479d
Compare
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
from
d26479d to
eec6010
Compare
|
@tore-espressif component |
tore-espressif
approved these changes
Oct 15, 2025
espzav
force-pushed
the
bsp/esp32_p4_eye
branch
from
eec6010 to
92727bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for new Board Support package or Component
urlfield definedChange description