fix(uac): Wait until requested bytes are read #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TempoTian can you please have a look if this fixes your problem? |
tore-espressif
force-pushed
the
fix/uac_ringbuf
branch
from
e3dd2c6 to
0d0b66b
Compare
|
@TempoTian have you had a chance to try this on real hardware? Can we go ahead with merging? |
leeebo
reviewed
Oct 20, 2025
leeebo
approved these changes
Oct 20, 2025
tore-espressif
force-pushed
the
fix/uac_ringbuf
branch
from
0d0b66b to
4b813b4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tore-espressif
force-pushed
the
fix/uac_ringbuf
branch
from
4b813b4 to
83446e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248
Previously
uac_host_device_read()would return early it there was data in the ringbuffer, but less than what was requested.Now, the function waits the entire timout until all data is received
ToDo