Skip to content

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Sep 26, 2025

No description provided.

@hfudev hfudev requested a review from Copilot September 26, 2025 14:03
@hfudev hfudev self-assigned this Sep 26, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR creates a new GitHub workflow to build ARMv7 wheels for tree-sitter-c version 0.21.4. The workflow sets up automated building of Python wheels specifically for ARMv7 architecture using self-hosted ARM runners.

  • Adds a new GitHub Actions workflow for building ARMv7 wheels
  • Configures the workflow to checkout tree-sitter-c at version v0.21.4
  • Sets up Python wheel building with cibuildwheel for native ARM architecture

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: "3.8"
Copy link
Preview

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.8 has reached end-of-life status in October 2024. Consider upgrading to a supported version like Python 3.9 or later for security updates and continued support.

Suggested change
python-version: "3.8"
python-version: "3.9"

Copilot uses AI. Check for mistakes.

Copy link

github-actions bot commented Sep 26, 2025

Warnings
⚠️ The Pull Request description is empty. Please provide a detailed description.

👋 Hello hfudev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b042325

@hfudev hfudev force-pushed the feat/build-tree-sitter-c branch 5 times, most recently from 2b52396 to 42de0d6 Compare September 26, 2025 14:55
@hfudev hfudev force-pushed the feat/build-tree-sitter-c branch from 42de0d6 to b042325 Compare September 26, 2025 14:58
@hfudev
Copy link
Member Author

hfudev commented Sep 26, 2025

@dobairoland I succeeded with a custom action. Please don't merge this MR.

I tested the built wheel on armv7, and it's working. could you help upload it to our internal pypi server? Thanks a lot!

@hfudev
Copy link
Member Author

hfudev commented Sep 26, 2025

@dobairoland
Copy link
Collaborator

dobairoland commented Sep 27, 2025

@hfudev It should be done: https://dl.espressif.com/pypi/tree-sitter-c/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants