Skip to content

Conversation

jakub-kocka
Copy link
Collaborator

@jakub-kocka jakub-kocka commented Sep 30, 2025

Description

  • Re-enabled upload of wheels for the defined action
  • README script requirements added in the workflow
  • Removed unused workflow "Create release" - there is no need to create releases of this repository
  • Added packages to the exclude list that are not supported by some older Python versions
  • Updated entries counter for "pretty" Espressif's PyPI (https://dl.espressif.com/pypi/pretty/)

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link

github-actions bot commented Sep 30, 2025

Warnings
⚠️ Please consider squashing your 6 commits (simplifying branch history).

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b63ad43

@jakub-kocka jakub-kocka changed the title Reenabled upload of wheels for the defined action Fixes of builds Oct 3, 2025
@jakub-kocka jakub-kocka self-assigned this Oct 3, 2025
Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mfialaf mfialaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-kocka
Copy link
Collaborator Author

Thank you guys for the review. I am merging this.

@jakub-kocka jakub-kocka merged commit 1eecd95 into main Oct 6, 2025
9 checks passed
@jakub-kocka jakub-kocka deleted the fix/wheels_fixtures branch October 6, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants