Move upgrade_3_0.md file to archives_upgrades folder #995

ronaldngounou · 2025-05-02T03:23:14Z

Overview

This PR aims to fix partially the issue #773.

My contributions:

I deleted the "Upgrading etcd clusters and applications" page.
I created a folder located in content/en/docs/v3.5/upgrades/archives_upgrades to contain upgrade archives. Then, I added the upgrades from 2.3 to 3.0, namely upgrade_3_0.md to that folder.

A second task related to this issue that this PR is not solving yet is to list document which upgrade paths are supported, recommended, deprecated, and unsupported at the top of the "Upgrading" main page.

I would suggest adding these versions in the list as I am waiting for approval.
recommended: [3.5.21] deprecated: [3.1, 3.2, 3.3, 3.4] unsupported: [2.3 to 3.0]

Testing

npm run serve

k8s-ci-robot · 2025-05-02T03:23:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ronaldngounou
Once this PR has been reviewed and has the lgtm label, please assign ivanvc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-05-02T03:23:23Z

Hi @ronaldngounou. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jberkus · 2025-06-03T17:33:44Z

content/en/docs/v3.5/upgrades/upgrading-etcd.md

Why did you delete this file?

@dwelsch-esi stated in the issue description that

The "Upgrading etcd clusters and applications" page seems redundant. The "Upgrading" link could goes straight to the main upgrade page, which contains the same information. There's no need to ever visit the Upgrading etcd clusters and applications page.

That's why I deleted that page.

jberkus · 2025-06-05T21:02:42Z

/retest

jberkus · 2025-06-05T21:53:08Z

We can ignore the linter failure since it's all content for the 3.0 page. However, I can't merge it until Netlify deploy succeeds, and it's not saying why it's failing. It may not even be related to your changes.

jberkus · 2025-06-05T21:54:11Z

/retest

ronaldngounou · 2025-06-06T04:37:15Z

The deployment is failing because target does not exist --- docs/v3.5/upgrades/upgrade_3_1/index.html --> ../upgrade_3_0. As I moved the upgrade_3.0.md file to the /upgrades/archives_upgrade folder, the reference to the page in upgrade_3.1.md in not the same anymore because the path changed.

ivanvc · 2025-06-06T05:38:04Z

/ok-to-test

This commit updates the link in the upgrade_3_1.md file to point to the archives upgrade page instead of the main upgrade page. This change ensures that users are directed to the correct page. Signed-off-by: Ronald Ngounou <[email protected]>

Signed-off-by: jasonnwu <[email protected]>

jberkus · 2025-06-06T23:07:50Z

You didn't actually need to fix the markdown issues with the 3.0 upgrade file ;-)

However: the move to the archives folder doesn't make any difference for anyone reading the documentation. Take a look at the preview; it still looks the same. This brings up the question of, what are we trying to do with the file move? It doesn't break anything, but it doesn't do anything either.

If we want to have some upgrades be "older version upgrades", then we'd need to put an _index in the Archive Upgrades folder, so that it gets displayed as one item. After that, it might be worth moving the 3.1 and 3.2 upgrades as well. But is that worth doing?

jberkus · 2025-06-06T23:15:19Z

So, I'm looking at #773, and what Dave is talking about has nothing to do with folders.

What Dave is asking for is some useful documentation on how to upgrade, in general, in the main _index page. That is, adding statements like The only supported method of upgrading is one feature version of etcd at a time. If you are currently on 3.4 and want to upgrade to 3.6, you will need to upgrade to 3.5 first.

It would also be useful to mark out the upgrade steps that have not been recently tested, which is anything before 3.4.

All of this would be done in the _index file.

This reverts commit eea0c34.

Signed-off-by: Ronald Ngounou <[email protected]>

…arch-2 Disable exclude_search in _index.md (3.6)

…gate_error Fix the issue of incorrect description of "operations." in the TxnModeWriteWithSharedBuffer function

Signed-off-by: Wendy Ha <[email protected]>

Signed-off-by: beifengtz <[email protected]>

Bumps [hugo-extended](https://github.com/jakejarvis/hugo-extended) from 0.147.5 to 0.147.8. - [Commits](jakejarvis/hugo-extended@v0.147.5...v0.147.8) --- updated-dependencies: - dependency-name: hugo-extended dependency-version: 0.147.8 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Add etcd-workbench link to tools

…hugo-extended-0.147.8 Bump hugo-extended from 0.147.5 to 0.147.8

Updates the requirements on [docsy](https://github.com/google/docsy) to permit the latest version. - [Release notes](https://github.com/google/docsy/releases) - [Commits](https://github.com/google/docsy/commits/ace4e37ceedcec9c48d329adb1128201061ef23d) --- updated-dependencies: - dependency-name: docsy dependency-version: ace4e37ceedcec9c48d329adb1128201061ef23d dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>

…docsy-0.12.0 Update docsy requirement from 0.11.0 to 0.12.0

Co-authored-by: Josh Berkus <[email protected]>

…al-how-to-transactional-write Revise website tutorial how-to-transactional-write

…rt2_clean Recursively copy the contents of v3.6 to v3.7

This commit updates the link in the upgrade_3_1.md file to point to the archives upgrade page instead of the main upgrade page. This change ensures that users are directed to the correct page. Signed-off-by: Ronald Ngounou <[email protected]>

This reverts commit eea0c34.

Signed-off-by: Ronald Ngounou <[email protected]>

This commit updates the link in the upgrade_3_1.md file to point to the archives upgrade page instead of the main upgrade page. This change ensures that users are directed to the correct page. Signed-off-by: Ronald Ngounou <[email protected]>

This reverts commit eea0c34.

…hub.com/ronaldngounou/etcd-io-website into issue773-upgrade-etcd-clusters-app-page

jberkus · 2025-06-30T23:56:55Z

Ooof, that did not go well. Here's my recommendation:

Make sure that your main branch is synced with upstream
Create a new branch based on main for the upgrades changes
copy over just the text of the changes to the index file.
Commit that and push it to a new branch
Open a new PR and reference this one.

k8s-ci-robot added needs-ok-to-test size/S labels May 2, 2025

jberkus reviewed Jun 3, 2025

View reviewed changes

ronaldngounou force-pushed the issue773-upgrade-etcd-clusters-app-page branch 3 times, most recently from 0a963d7 to b5635cb Compare June 6, 2025 05:02

k8s-ci-robot added size/M and removed size/S labels Jun 6, 2025

ronaldngounou force-pushed the issue773-upgrade-etcd-clusters-app-page branch 2 times, most recently from d201ded to ea0a2d2 Compare June 6, 2025 05:34

k8s-ci-robot added ok-to-test do-not-merge/hold and removed needs-ok-to-test labels Jun 6, 2025

ronaldngounou force-pushed the issue773-upgrade-etcd-clusters-app-page branch from 9f1dcd2 to eea0c34 Compare June 6, 2025 05:50

update the doc/v3.6/feature_gate details some errors

d5288ff

Signed-off-by: jasonnwu <[email protected]>

ronaldngounou added 3 commits June 7, 2025 08:56

Merge branch 'main' into issue773-upgrade-etcd-clusters-app-page

88c1ab4

Revert "Move upgrade_3_0.md file to archives_upgrades folder"

d4b44a4

This reverts commit eea0c34.

Add a statement in _index file to clarify upgrade steps.

2867534

Signed-off-by: Ronald Ngounou <[email protected]>

k8s-ci-robot added size/XS and removed size/M labels Jun 7, 2025

jberkus and others added 26 commits June 12, 2025 15:39

Merge pull request etcd-io#1026 from ronaldngounou/disable-exclude_se…

17f2bdb

…arch-2 Disable exclude_search in _index.md (3.6)

Merge pull request etcd-io#1022 from Jason040906/update_v3.6_feature_…

b2bea26

…gate_error Fix the issue of incorrect description of "operations." in the TxnModeWriteWithSharedBuffer function

etcd-website: backport how to transactional write from v3.6 to v3.5

ab102aa

Signed-off-by: Wendy Ha <[email protected]>

etcd-website:fix git rebase

0a8fb97

Signed-off-by: Wendy Ha <[email protected]>

etcd-website: fix MD047 single trailing new line rule failed

ca52bc7

Signed-off-by: Wendy Ha <[email protected]>

etcd-website: fix MD047 single trailing new line rule failed

15bff09

Signed-off-by: Wendy Ha <[email protected]>

etcd-website: fix MD047 single trailing new line rule failed on v3.5

861d419

Signed-off-by: Wendy Ha <[email protected]>

Add etcd-workbench link to tools

8b8788a

Signed-off-by: beifengtz <[email protected]>

Added a statement on the integrations page for versions 3.2 and 3.3.

20728c4

Signed-off-by: beifengtz <[email protected]>

etcdwebsite: fix linting issues

8cfcc10

Signed-off-by: beifengtz <[email protected]>

etcdwebsite: fix linting issues in v3.4

a5fc923

Signed-off-by: beifengtz <[email protected]>

Merge pull request etcd-io#1027 from tzfun/main

f9584d9

Add etcd-workbench link to tools

Merge pull request etcd-io#1028 from etcd-io/dependabot/npm_and_yarn/…

40806e0

…hugo-extended-0.147.8 Bump hugo-extended from 0.147.5 to 0.147.8

Merge pull request etcd-io#1014 from etcd-io/dependabot/npm_and_yarn/…

1b1c378

…docsy-0.12.0 Update docsy requirement from 0.11.0 to 0.12.0

Update content/en/docs/v3.5/tutorials/how-to-transactional-write.md

e31896c

Co-authored-by: Josh Berkus <[email protected]>

Update content/en/docs/v3.6/tutorials/how-to-transactional-write.md

34c1924

Co-authored-by: Josh Berkus <[email protected]>

Merge pull request etcd-io#1025 from wendy-ha18/wendyha-update-tutori…

b8ea578

…al-how-to-transactional-write Revise website tutorial how-to-transactional-write

Merge pull request etcd-io#1019 from ronaldngounou/issue1012-v_3.6_Pa…

7eeff43

…rt2_clean Recursively copy the contents of v3.6 to v3.7

Revert "Move upgrade_3_0.md file to archives_upgrades folder"

2993695

This reverts commit eea0c34.

Add a statement in _index file to clarify upgrade steps.

67ad96d

Signed-off-by: Ronald Ngounou <[email protected]>

Revert "Move upgrade_3_0.md file to archives_upgrades folder"

d24fe40

This reverts commit eea0c34.

Merge branch 'issue773-upgrade-etcd-clusters-app-page' of https://git…

633a36a

…hub.com/ronaldngounou/etcd-io-website into issue773-upgrade-etcd-clusters-app-page

k8s-ci-robot added size/XXL and removed size/XS labels Jun 28, 2025

ronaldngounou closed this Oct 1, 2025

Move upgrade_3_0.md file to archives_upgrades folder #995

Move upgrade_3_0.md file to archives_upgrades folder #995

Uh oh!

Conversation

ronaldngounou commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Testing

Uh oh!

k8s-ci-robot commented May 2, 2025

Uh oh!

k8s-ci-robot commented May 2, 2025

Uh oh!

jberkus Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

ronaldngounou Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

jberkus Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

jberkus commented Jun 5, 2025

Uh oh!

jberkus commented Jun 5, 2025

Uh oh!

jberkus commented Jun 5, 2025

Uh oh!

ronaldngounou commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivanvc commented Jun 6, 2025

Uh oh!

jberkus commented Jun 6, 2025

Uh oh!

jberkus commented Jun 6, 2025

Uh oh!

jberkus commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ronaldngounou commented May 2, 2025 •

edited

Loading

ronaldngounou commented Jun 6, 2025 •

edited

Loading