Skip to content

Conversation

jgphpc
Copy link
Collaborator

@jgphpc jgphpc commented Aug 26, 2025

  • Adding /capstor/store/cscs/cscs/public/reframe/resources as resourcesdir

@jgphpc jgphpc requested review from Copilot and gppezzi August 26, 2025 12:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the resourcesdir configuration across multiple system configuration files by setting all systems to use the same resource directory path /capstor/store/cscs/cscs/public/reframe/resources.

  • Adds resourcesdir configuration to systems that previously lacked it
  • Updates existing resourcesdir paths to use the standardized location
  • Removes commented-out resource directory configurations

Reviewed Changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
config/systems/santis.py Adds resourcesdir configuration to site_configuration
config/systems/pilatus.py Updates resourcesdir path from old location to standardized path
config/systems/eiger.py Adds resourcesdir configuration to site_configuration
config/systems/daint.py Replaces commented resourcesdir with active standardized path
config/systems/clariden.py Adds resourcesdir configuration to base_config
config/systems/bristen.py Adds resourcesdir configuration to base_config
config/systems/beverin.py Adds resourcesdir configuration to base_config

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gppezzi
Copy link
Collaborator

gppezzi commented Aug 28, 2025

I don't know about all kinds of artifacts we're going to store here, but we might need to consider the different architectures in the folder organization?

let's discuss in the weekly meeting

@jgphpc jgphpc merged commit 89b3036 into eth-cscs:main Sep 1, 2025
1 check passed
@jgphpc jgphpc deleted the resources branch September 1, 2025 07:33
@jgphpc jgphpc mentioned this pull request Sep 1, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants