-
Notifications
You must be signed in to change notification settings - Fork 27
Update cuda tests and fix CI #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CUDA NVML test configuration to fix compatibility issues with different programming environments and UENV configurations. The changes align environment features and improve the test's ability to locate CUDA installations across different setups.
- Added 'cpe' and 'ce' features to programming environments for proper test filtering
- Enhanced CUDA path detection logic to work with both CUDA_HOME and UENV configurations
- Updated valid programming environment filters for both CPE and UENV test variants
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
config/systems/daint.py | Adds 'cpe' and 'ce' feature tags to programming environments |
checks/prgenv/cuda_nvml.py | Updates environment filters and improves CUDA path detection logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/25.06:rc5 |
cscs-ci run alps-daint-cpe |
cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/25.06:rc5 |
cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/25.06:rc5 |
cscs-ci run alps-daint-cpe |
cscs-ci run alps-daint-cpe |
cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/25.06:rc5 |
cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/25.06:rc5 |
cscs-ci run alps-daint-cpe |
cscs-ci run alps-daint-uenv
comment in the Pull Requestcscs-ci run alps-daint-uenv;MY_UENV=cp2k/2025.1:v2
Thank you for taking the time to contribute to
cscs-reframe-tests
!