Allow queryTransform to return a promise #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already the case that queryTransform can return a promise for a RunnableQuery instead of a Runnable query but it was not in the type definition or covered in any test so I've added those two things.
Unfortunately I couldn't get the tests to run, I get the following error
Error: Cannot find module 'superagent'. As far as I can tell, superagent is present in the node_modules after installing but there is no JS entry point. I'm not quite sure what is going on there. I therefore can't confirm whether the test I wrote passes. I can at least be fairly sure that I didn't break any other tests as all I changed is a type definition.