Add MITY

[scagria]

Adding Fission Bio (MITY)

Ethereum: https://etherscan.io/token/0xd07ea8776e52c1b67dca6ffbc3f659fc9fbe4113

Base: https://basescan.org/token/0x1fbaf8bdc2a43b0c9ba90b6caf44ee14d2ee6773

[wiz-inc-a178a98b5d]

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	1
Total	1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

[scagria]

hey @wbnns, hope you are doing good! any news on that pr?

[fainashalts]

Hi @scagria can you rebase against master? Your PR is failing CICD but I just merged a fix that might help.

[scagria]

hey @fainashalts, can you check now?

[scagria]

Hello, how long does it take normally to be review?

[wiz-inc-a178a98b5d]

 Sensitive Data Finding

Financial

More Details

Attribute	Value
Data Classifier	Financial/Ethereum Address
Data Classifier ID	BUILTIN-388

Sampled Examples

Key	Value
ethereum.address	0x*eA...**13 (42 chars)

Rule ID: BUILTIN-388

To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason

If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).

[scagria]

@fainashalts can you help me understand why its failing? pr is following the rules and this isn’t the first token integration pr we have created - it follows the same pattern. so why is this one failing the check? the l1 token name and l2 token names are different, so i made a change in the json file assuming that might be the issue but it is still failing. it would be great if i can get a response, as this is delaying our launch. thank you!

[fainashalts]

Hi @scagria I'm looking into it, will try to get this sorted out asap!

[scagria]

thank you!

[fainashalts]

Hi @scagria thank you for your patience! I took a close look at this PR and it looks like the issue is that the name on Ethereum is different from what you have in the json. We can add a per-chain override to fix this, like so:

{
  "name": "Fission Bio",
  "symbol": "MITY",
  "decimals": 18,
  "description": "Fission Bio IP Token",
  "website": "https://www.cerebrumdao.com/projects/fission-bio",
  "twitter": "@FissionBioDeSci",
  "tokens": {
    "ethereum": {
      "address": "0xd07eA8776e52c1b67dcA6ffBC3F659Fc9fbe4113",
      "overrides": {
        "name": "IP Tokens of IPNFT",
        "symbol": "MITY",
        "decimals": 18
      }
    },
    "base": {
      "address": "0x1fbaf8bDc2A43b0c9BA90b6caF44EE14d2EE6773"
    }
  }
}

I added a suggested commit to fix this. Please let me know if you have any questions!

[scagria]

@fainashalts done, thank you for the help!